Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functionality to fetch releases #45

Closed
yarikoptic opened this issue May 13, 2021 · 2 comments · Fixed by #48
Closed

Functionality to fetch releases #45

yarikoptic opened this issue May 13, 2021 · 2 comments · Fixed by #48
Assignees

Comments

@yarikoptic
Copy link
Member

Having filing #44 triggered greedy me also into thinking on how to fold "releases" into the picture here, since that is where we also provide assets (https://github.com/datalad/git-annex/releases/tag/8.20210428) worth archival. For that I guess we just need to establish

  • {type} == "release"
  • {type_id} == release name
  • {commit}/ -- well the commit it points to

and then it would become all consistent and nice across PRs etc. The only aspect I see is to make releases location possibly different from PRs etc builds, so also filed #43 to improve flexibility etc.

@jwodder
Copy link
Member

jwodder commented May 14, 2021

@yarikoptic By "fetch releases," do you mean just fetching release assets? Should the path for downloading releases be specified by a separate variable from the logs download path? Are you sure you want {type_id} to be the release name (which for, say, this would be "v0.1.0 — Initial release") rather than the tag name? Should prereleases and/or draft releases be included?

@yarikoptic
Copy link
Member Author

@yarikoptic By "fetch releases," do you mean just fetching release assets?

yes

Should the path for downloading releases be specified by a separate variable from the logs download path?

yes

Are you sure you want {type_id} to be the release name (which for, say, this would be "v0.1.0 — Initial release") rather than the tag name?

I do want just pure tag, not release name. But I think (since in our control) we can make {type_id} for release to be the tag if known. If not -- then indeed we are doomed to go for the "name" of that release.

Should prereleases and/or draft releases be included?

make it optional? for current use case we do not need those AFAIK since we post only final releases for datalad/git-annex.

yarikoptic added a commit that referenced this issue May 17, 2021
Support downloading GitHub release assets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants