-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add {timestamp}
and {timestamp_local}
placeholders
#114
Conversation
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
===========================================
+ Coverage 44.45% 72.12% +27.67%
===========================================
Files 9 10 +1
Lines 893 897 +4
Branches 134 134
===========================================
+ Hits 397 647 +250
+ Misses 495 196 -299
- Partials 1 54 +53
Continue to review full report at Codecov.
|
I wonder on what is the motivation/use-case this would address? I do not quite grasp on why I might need a local time stamp, and otherwise we do have all the components (year, month, etc) of the build available. |
@yarikoptic |
So, at large, Might be overkill, but in principle it could be some |
Yes.
Personally, I think formatting a datetime with strftime formats is more natural than defining a separate placeholder for each field.
I don't think implementing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, since code-wise seems to be correct, I approve. I personally have reservations on introducing _local
to timestamp
while leaving all the broke down ones without zone conversion. I personally would unlikely to use _local
since repository is to be shared/reused by different members of the team which might reside in different timezones, and thus adding _local
would only be of a cons
to others. So I leave at @jwodder discretion on adding _local
handling in this PR.
No description provided.