adding support to run twice #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sometimes we add a new contributor on a run, and once we have basic metadata a second PR is opened shortly after with this additional metadata (that we could not look up before because we did not have them recorded). This change will add a new variable run_twice to the action to allow the user to run the workflow twice instead of once to reduce the updates to one PR. Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
|
Worked like a charm! The first run added new contributors and all metadata, then the second run didn't find anything. (no second PR). Right now it's sort of a bug that the first update finds new GitHub aliases, and then it takes a second one to use other extractors to get metadata about them. |
yarikoptic
reviewed
Mar 16, 2022
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
yarikoptic
reviewed
Mar 16, 2022
vsoch
commented
Mar 16, 2022
action.yml
Outdated
| @@ -43,6 +43,9 @@ inputs: | |||
| allcontrib_skip_generate: | |||
| description: "skip running all-contributors generate" | |||
| default: false | |||
| run_twice: | |||
| description: "run twice to avoid opening two pull requests" | |||
| default: false | |||
There was a problem hiding this comment.
@yarikoptic here is the default for INPUT_RUN_TWICE
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
|
okay default is updated! 6855abe |
|
ping @yarikoptic ! |
|
sorry - fell off my radar. Thanks! Let's see it in action |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we add a new contributor on a run, and once we have basic metadata a second PR is opened shortly after with this additional metadata (that we could not look up before because we did not have them recorded). This change will add a new
variable run_twice to the action to allow the user to run the workflow twice instead of once to reduce the updates to one PR.
I will test the branch on one of my projects where I'm expecting contributors to be found, and it would need to be run twice!
Signed-off-by: vsoch vsoch@users.noreply.github.com