Enable eslint rule explicit-function-return-type (#960)

.eslintrc.js

@@ -104,6 +104,10 @@ module.exports = {
     "@typescript-eslint/ban-ts-comment": "error",
     "@typescript-eslint/no-explicit-any": "error",
     "@typescript-eslint/explicit-module-boundary-types": "error",
+    "@typescript-eslint/explicit-function-return-type": [
+      "error",
+      { allowExpressions: true },
+    ],
     "@typescript-eslint/require-array-sort-compare": [
       "error",
       { ignoreStringArrays: true },

client/eslint-config-client.json

@@ -304,6 +304,12 @@
     ],
     "@typescript-eslint/no-explicit-any": ["error"],
     "@typescript-eslint/explicit-module-boundary-types": ["error"],
+    "@typescript-eslint/explicit-function-return-type": [
+      "error",
+      {
+        "allowExpressions": true
+      }
+    ],
     "@typescript-eslint/require-array-sort-compare": [
       "error",
       {

client/src/views/all-program-items/components/AllProgramItemsList.tsx

@@ -15,6 +15,7 @@ import {
 } from "client/views/my-program-items/myProgramItemsSlice";
 import { RaisedCard } from "client/components/RaisedCard";
 import { getIsInGroup } from "client/views/group/groupUtils";
+import { SignupQuestion } from "shared/types/models/settings";
 
 interface Props {
   programItems: readonly ProgramItem[];
@@ -46,7 +47,9 @@ export const AllProgramItemsList = ({ programItems }: Props): ReactElement => {
     (state) => state.admin.signupQuestions,
   );
 
-  const getPublicSignupQuestion = (programItemId: string) =>
+  const getPublicSignupQuestion = (
+    programItemId: string,
+  ): SignupQuestion | undefined =>
     signupQuestions.find(
       (s) => s.programItemId === programItemId && !s.private,
     );

client/src/views/all-program-items/components/ProgramItemInfo.tsx

@@ -13,7 +13,7 @@ interface Props {
 export const ProgramItemInfo = ({ programItem }: Props): ReactElement => {
   const { t } = useTranslation();
 
-  const formatTime = () => {
+  const formatTime = (): string => {
     const hours = Math.floor(programItem.mins / 60);
     const minutes = Math.round((programItem.mins / 60 - hours) * 60);
 

server/eslint-config-server.json

@@ -201,6 +201,12 @@
     ],
     "@typescript-eslint/no-explicit-any": ["error"],
     "@typescript-eslint/explicit-module-boundary-types": ["error"],
+    "@typescript-eslint/explicit-function-return-type": [
+      "error",
+      {
+        "allowExpressions": true
+      }
+    ],
     "@typescript-eslint/require-array-sort-compare": [
       "error",
       {

server/src/kompassi/getProgramItemsFromKompassi.ts

@@ -56,7 +56,7 @@ export const getProgramItemsFromKompassi = async (
     : makeSuccessResult(programItems);
 };
 
-const getProgramItemId = (programItem: unknown) => {
+const getProgramItemId = (programItem: unknown): unknown => {
   return !!programItem &&
     typeof programItem === "object" &&
     "slug" in programItem

server/src/utils/sentry-winston-transport.ts

@@ -9,6 +9,7 @@ eslint-disable
 @typescript-eslint/no-floating-promises,
 @typescript-eslint/no-unnecessary-condition,
 @typescript-eslint/consistent-indexed-object-style,
+@typescript-eslint/explicit-function-return-type,
 promise/catch-or-return,
 promise/always-return,
 curly
@@ -170,6 +171,7 @@ eslint-enable
 @typescript-eslint/no-floating-promises,
 @typescript-eslint/no-unnecessary-condition,
 @typescript-eslint/consistent-indexed-object-style,
+@typescript-eslint/explicit-function-return-type,
 promise/catch-or-return,
 promise/always-return,
 curly

shared/utils/signupTimes.test.ts

@@ -190,7 +190,7 @@ describe(`Direct signup with signup windows`, () => {
   const testLarp = { ...testProgramItem, programType: ProgramType.LARP };
   const testLarp2 = { ...testProgramItem2, programType: ProgramType.LARP };
 
-  const assertSignupTime = (startTime: string, signupTime: string) => {
+  const assertSignupTime = (startTime: string, signupTime: string): void => {
     const signupStartTime = getDirectSignupStartTime({
       ...testLarp,
       startTime,
@@ -263,7 +263,7 @@ describe(`Direct signup with rolling signup`, () => {
     programType: ProgramType.WORKSHOP,
   };
 
-  const assertSignupTime = (startTime: string, signupTime: string) => {
+  const assertSignupTime = (startTime: string, signupTime: string): void => {
     const signupStartTime = getDirectSignupStartTime({
       ...testWorkshop,
       startTime,

yarn.config.cjs

@@ -4,13 +4,15 @@ const { defineConfig } = require("@yarnpkg/types"); // eslint-disable-line @type
 // https://yarnpkg.com/features/constraints
 
 // Enforce that the engines.node field is properly set in all workspaces
+// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 const enforceConsistentEnginesNodeValue = ({ Yarn }) => {
   for (const workspace of Yarn.workspaces()) {
     workspace.set("engines.node", ">=20.12.2");
   }
 };
 
 // Enforce that a workspaces depend on the same version of a dependency
+// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 const enforceConsistentDependencies = ({ Yarn }) => {
   for (const dependency of Yarn.dependencies()) {
     if (dependency.type === `peerDependencies`) {