Split Data.NumInstances into two modules, one for function instances and one for tuples #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, someone wishing to get (say) just the tuple instances can import Data.NumInstances.Tuple and not get the function instances. This change should be completely backwards-compatible. See diagrams/diagrams-lib#48 and https://groups.google.com/forum/?fromgroups=#!topic/diagrams-discuss/c3KhwQO3L_g .
|
I like this splitting. Thanks very much for the patch. I merged it, made a couple of very small tweaks, and released to hackage. |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, someone wishing to get (say) just the tuple instances can
import
Data.NumInstances.Tupleand not get the function instances.This change should be completely backwards-compatible.
See diagrams/diagrams-lib#48 and
https://groups.google.com/forum/?fromgroups=#!topic/diagrams-discuss/c3KhwQO3L_g .