Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set boost required version to 1.85.0 to be inline with thrift/0.17.0 … #24458

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maximiliank
Copy link
Contributor

@maximiliank maximiliank commented Jun 27, 2024

Adjust boost version dependency for arrow/all

Summary

Changes to recipe: arrow/all

Motivation

In the latest commit to the thrift recipe (f8a8a29) the boost version requirement was set to 1.85.0. This results in a version conflict when arrow is requested with any option requiring with_thrift (e.q. parquet requires this)

Details

Solution is to increase the boost version to 1.85.0. Solves #24455


@CLAassistant
Copy link

CLAassistant commented Jun 27, 2024

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! With the new pipeline we'll be able to handle cases like this in a simpler way by being able to modify more than once recipe per PR, sorry that this was an issue meanwhile :)

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@maximiliank
Copy link
Contributor Author

Unfortunately, I cannot view the details about the failing required checks c3i/conan-v2/pr-merge and continuous-integration/jenkins/pr-merge. How should I proceed here?

@AbrilRBS
Copy link
Member

Hi @maximiliank sorry for the bot noise - our CI got a bit confused, that's also the reason you couldn't see the logs. I've restarted the build now, let's see if it's happier about it this time around :)

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

Should be fixed now 🤞 , sorry for the noise @maximiliank - if this gives more problems, I'll have to dig deeper on monday

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

🚦 Thank for your Bump dependencies PR. The build service will be triggered soon by a Conan team member.

@maximiliank
Copy link
Contributor Author

Now 60 more fail and I still get a 403 Forbidden on the 3ci/conan-v2/pr-merge and continuous-integration/jenkins/pr-merge checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants