Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check astroid == 1.6 false positives #2164

Closed
memsharded opened this issue Dec 17, 2017 · 8 comments
Closed

Check astroid == 1.6 false positives #2164

memsharded opened this issue Dec 17, 2017 · 8 comments

Comments

@memsharded
Copy link
Member

cc1eed7

@memsharded
Copy link
Member Author

Reported in pylint repo: pylint-dev/pylint#1784

@lasote lasote modified the milestones: 1.0, 1.0.0-beta1 Dec 20, 2017
@memsharded
Copy link
Member Author

The suggested approach in pylint-dev/pylint#1784 (comment) is to just use astroid 1.5.3. This is already done, so there is little more we can do here.

@memsharded memsharded removed this from the 1.0 milestone Dec 22, 2017
@tivek
Copy link
Contributor

tivek commented Dec 22, 2017

Arch Linux already has official python-astroid 1.6.0 packages, which means Conan 0.30.3 cannot be packaged for this distro without conflicting official repos. Are there any contingency plans?

@memsharded
Copy link
Member Author

I don't see how this can be fixed :(
It doesn't seem the pylint-astroid maintainers are willing to fix this at the moment. Any ideas?

@tivek
Copy link
Contributor

tivek commented Dec 22, 2017

According to pylint-dev/pylint#1790 upgrading to pylint 1.8 should help. My quick'n'dirty tests with pylint 1.8.1 and astroid 1.6.0 seem to be fine. Can you please check?

@memsharded
Copy link
Member Author

@tivek In Python3 too? I recall trying it in Win Py3 with Astroid 1.6.0 and the issue was still there.

@tivek
Copy link
Contributor

tivek commented Dec 23, 2017

Python 3.6.4, pylint 1.8.1, astroid 1.6.0 in a clean conda env, I don't get the pylint-dev/pylint#1790 bug. I will try to get TravisCI to run tests with pylint 1.8.1 and astroid 1.6.0.

@tivek
Copy link
Contributor

tivek commented Dec 23, 2017

Yay, TravisCI and AppVeyor pass the tests. If bumping pylint and astroid requirements is ok, hopefully this can get into Conan 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants