Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InvalidConfigurationException to be raised in Conanfile.configure() #3484

Closed
jgsogo opened this issue Sep 5, 2018 · 1 comment · Fixed by #3517
Closed

Add InvalidConfigurationException to be raised in Conanfile.configure() #3484

jgsogo opened this issue Sep 5, 2018 · 1 comment · Fixed by #3517
Assignees
Milestone

Comments

@jgsogo
Copy link
Contributor

jgsogo commented Sep 5, 2018

Copy here the issue discussed at conan-package-tools conan-io/conan-package-tools#146:

Motivation.- Protobuf package has an issue with windows/shared configuration so we have to disable it and prevent CI to run those jobs in order to get a green badge.

What to ask for.- I think that it would be useful to have a conan.errors.InvalidConfigurationException (better name?) to be raised from configure() method in recipes instead of the generic ConanException (as it is suggested here). This way users will get the proper information when running conan, but projects like conan-package-tools can catch this specific exception, handle it and mark the job in CI as successful.

This way we don't need to tweak build.py files to avoid running certain configurations, so we move forwards to a even more standarized (unneeded) file.

Will require to add the exception type and document it (here), I think that Conan's internals won't be affected by it.

@lasote lasote added this to the 1.8 milestone Sep 6, 2018
@lasote
Copy link
Contributor

lasote commented Sep 6, 2018

The conan application has to return a different return number when that exception is raised, to detect even without running in a python script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants