Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faulty check of LOCKFILE_VERSION in graph_lock.py #7245

Closed
sssgtg opened this issue Jun 24, 2020 · 2 comments · Fixed by #7243
Closed

Faulty check of LOCKFILE_VERSION in graph_lock.py #7245

sssgtg opened this issue Jun 24, 2020 · 2 comments · Fixed by #7243
Assignees
Milestone

Comments

@sssgtg
Copy link

sssgtg commented Jun 24, 2020

The following check is performed in graph_lock.py:

if version < "0.2":
raise ConanException("This lockfile was created with a previous incompatible "
"version. Please regenerate the lockfile")

This means that the exception will not be thrown if you try to use a lockfile of version 0.2 if Conan (for example 1.25.2) use 0.3. Instead it will crash with other exceptions.

@memsharded
Copy link
Member

Hi @sssgtg

That is true, thanks for reporting. We are doing a major upgrade to the lockfile functionality in #7243, it will be addressed there.

@memsharded memsharded modified the milestones: 1.27, 1.28 Jun 29, 2020
@memsharded
Copy link
Member

Fixed in #7243 for Conan 1.28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants