Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Move the definition of CMakeDeps variables to its own file #8593

Closed
memsharded opened this issue Mar 3, 2021 · 0 comments · Fixed by #8655
Closed

[feature] Move the definition of CMakeDeps variables to its own file #8593

memsharded opened this issue Mar 3, 2021 · 0 comments · Fixed by #8655
Assignees
@danimtb
Labels
component: Build Build helpers, build systems.. type: feature
Milestone
1.35

Comments

@memsharded
Copy link
Member

  • For each dependency, for each configuration, lets create a xxxx-release-x64-data.cmake file that will contain exclusively the variables definitions from the dependencies.
  • No logic, no macro calls
  • No repeated variables like _INCLUDE_DIRS, _INCLUDEDIRS, _INCLUDES, only 1
@memsharded memsharded added this to the 1.35 milestone Mar 3, 2021
@memsharded memsharded added component: Build Build helpers, build systems.. type: feature labels Mar 3, 2021
@danimtb danimtb mentioned this issue Mar 16, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danimtb danimtb

Labels
component: Build Build helpers, build systems.. type: feature
Projects
None yet
Milestone
1.35
Development

Successfully merging a pull request may close this issue.

Feature/cmakedeps files danimtb/conan
2 participants
@danimtb @memsharded