Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] win_bash new approach #9068

Closed
memsharded opened this issue Jun 7, 2021 · 0 comments · Fixed by #9194
Closed

[feature] win_bash new approach #9068

memsharded opened this issue Jun 7, 2021 · 0 comments · Fixed by #9194
Assignees
Milestone

Comments

@memsharded
Copy link
Member

memsharded commented Jun 7, 2021

The current win_bash and run_in_windows_bash needs some improvements. This ticket would be the first iteration for improving that, to better serve the new build system integrations and for Conan 2.0.
Important points:

  • It should have strictly 0 auto-detection. All information that it would need should be extracted from settings or new [conf]
  • It should have a simple win_bash=True syntax, not necessary to do ugly checks in recipes about the platform. Internally, it should do nothing if not in Windows.
  • It should use strictly the 2 profiles approach.
  • Consider skipping using the WSL as a win_bash, as that would be a Linux environment, not a Windows one?
  • tools.run_in_windows_bash() can probably be dropped if nicely supported in self.run(..., win_bash=True)
  • No need to integrate it with the existing build integrations, or to be backwards compatible, it can be treated as a completely new feature to replace the previous one.

Start simple, probably just the bash wrapper itself, but not necessarily handling all the possible environment and path (cygwin, and the like) variants.

Related issue: #8883, difficult to solve without breaking...

@memsharded memsharded added this to the 1.38 milestone Jun 7, 2021
@tapia tapia assigned lasote and czoido and unassigned tapia Jun 8, 2021
@memsharded memsharded modified the milestones: 1.38, 1.39 Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants