Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature+bug] conan.tools.gnu.autotools.Autotools can only configure in root source folder #9375

Closed
madebr opened this issue Aug 4, 2021 · 3 comments · Fixed by #9393
Closed

Comments

@madebr
Copy link
Contributor

madebr commented Aug 4, 2021

Some times, configure scripts can be found in subdirectories.
Right now, ConanFile.source_folder is hard coded at

configure_cmd = "{}/configure".format(self._conanfile.source_folder)

It would be VERY useful to be able to change this.

Environment Details (include every applicable attribute)

  • Operating System+version: all
  • Compiler+version: all
  • Conan version: 1.39.0
  • Python version: 3.9.6
@lasote lasote self-assigned this Aug 5, 2021
@lasote
Copy link
Contributor

lasote commented Aug 5, 2021

Sure, let's do it.

Same as the new CMake one:

    def configure(self, source_folder=None):
        ...

        source = self._conanfile.source_folder
        if source_folder:
            source = os.path.join(self._conanfile.source_folder, source_folder)

@madebr
Copy link
Contributor Author

madebr commented Aug 5, 2021

I'm not properly versed in Conan's layout model,
but should Autotools follow it too?

@lasote
Copy link
Contributor

lasote commented Aug 6, 2021

Yes, I meant that the conan.tools.gnu.autotools.Autotools should do something similar to the current CMake one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants