Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default cmake_layout() source folder #9549

Closed
memsharded opened this issue Sep 7, 2021 · 2 comments · Fixed by #9596
Closed

Default cmake_layout() source folder #9549

memsharded opened this issue Sep 7, 2021 · 2 comments · Fixed by #9596
Assignees
@tapia @lasote
Milestone
1.40.1

Comments

@memsharded
Copy link
Member

This layout is assuming that the main library CMakeLists.txt is inside a src subfolder in the repo.

This is probably not the most common user layout, in which they will have a CMakeLists.txt in the root of the folder:

  • How to model this?
  • Should we change the cmake_layout() default to folders.source = "."?
  • Check implications of defining the root as source folder.
@memsharded memsharded added this to the 1.41 milestone Sep 7, 2021
@mpusz
Copy link

mpusz commented Sep 7, 2021

A good reason for having a CMakeLists.txt file in the project root is that is used as an entry point for most IDEs. Having it in the src subdirectory could be problematic for some IDEs.

@tapia tapia self-assigned this Sep 9, 2021
@tapia tapia mentioned this issue Sep 13, 2021
Merged
@lasote lasote modified the milestones: 1.41, 1.40.1 Sep 14, 2021
@lasote
Copy link
Contributor

lasote commented Sep 14, 2021

Merged to be released at 1.40.1

@lasote lasote closed this as completed Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tapia tapia

@lasote lasote

Labels
None yet
Projects
None yet
Milestone
1.40.1
Development

Successfully merging a pull request may close this issue.

Change default cmake_layout() source folder tapia/conan
4 participants
@mpusz @tapia @lasote @memsharded