New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop2] Simplifying the Options model #9840
Merged
memsharded
merged 26 commits into
conan-io:develop2
from
memsharded:feature/develop2_new_options
Nov 2, 2021
Merged
[develop2] Simplifying the Options model #9840
memsharded
merged 26 commits into
conan-io:develop2
from
memsharded:feature/develop2_new_options
Nov 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasote
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 🥇
czoido
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Omit
Docs: Omit
New proposal to simplify Options:
OptionValues
,PkgOptionValues
,PkgOptionValue
classes that duplicate too much of the model, making it way more complex.Options
classOptions
class and its collaboratorsbuild_options
in recipes, but that will follow in another PRconaninfo.txt
now are very minimal, just derived from the fact that not all options from dependencies are stored there now. This will change, but in a following PR, to keep this more focused.Close #9900