Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop2] Simplifying the Options model #9840

Merged
merged 26 commits into from Nov 2, 2021

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Oct 20, 2021

Changelog: Omit
Docs: Omit

New proposal to simplify Options:

  • Remove the OptionValues, PkgOptionValues, PkgOptionValue classes that duplicate too much of the model, making it way more complex.
  • Isolated the implementation, the only public interface to options is now the Options class
  • Some simplifications in the Options class and its collaborators
  • Changed how options are propagated in the graph, separating the options that are modified by downstream dependencies from the options that are self-defined or defined by profiles, because that massively affects things like build-order
  • This change in propagation should help to prepare for better propagation in the "build" context. This might still need some new model, like build_options in recipes, but that will follow in another PR
  • Changes in the conaninfo.txt now are very minimal, just derived from the fact that not all options from dependencies are stored there now. This will change, but in a following PR, to keep this more focused.

Close #9900

@memsharded memsharded marked this pull request as ready for review October 29, 2021 00:07
Copy link
Contributor

@lasote lasote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🥇

@memsharded memsharded merged commit e0df8f5 into conan-io:develop2 Nov 2, 2021
@memsharded memsharded deleted the feature/develop2_new_options branch November 2, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants