Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build missing warning message #1616

Merged
merged 4 commits into from Mar 23, 2020

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Mar 20, 2020

Update missing package warning message:

  • Using CCI package czmq for demonstration;
  • Added the new information: Requirements;
  • There is only one occurrence of that warning message in docs;
  • As semver_direct_mode is not affected by minor and patch version, all requirements show placeholders.

Related issue: conan-io/conan#6700

Signed-off-by: Uilian Ries <uilianries@gmail.com>
faq/troubleshooting.rst Outdated Show resolved Hide resolved
@jgsogo jgsogo added this to the 1.24 milestone Mar 20, 2020
@uilianries uilianries force-pushed the feature/print-missing-details branch from 2fd8514 to 835960c Compare Mar 20, 2020
Signed-off-by: Uilian Ries <uilianries@gmail.com>
faq/troubleshooting.rst Outdated Show resolved Hide resolved
jgsogo
jgsogo approved these changes Mar 23, 2020
@memsharded
Copy link
Member

@memsharded memsharded commented Mar 23, 2020

@jgsogo PRs keep failing for unrelated links checks. I suggested completely removing them, leaving them only in nightlies or similar.

@jgsogo
Copy link
Member

@jgsogo jgsogo commented Mar 23, 2020

Those links are actually broken

@memsharded
Copy link
Member

@memsharded memsharded commented Mar 23, 2020

Those links are actually broken

Still, not the fault of this PR, and this kind of errors happen on PR a bit too much for my taste, some unrelated link to the PR that doesn't respond and breaks the PR contribution, which cannot longer be merged even if it is clear that the error is unrelated.

@jgsogo
Copy link
Member

@jgsogo jgsogo commented Mar 23, 2020

My main concern is not realizing that these links are broken and failing in master (now it is broken, did anyone realize that? what is missing in the docs and for how long?). We will merge a PR, think that everything is done and the docs are published, but no, because of the failure we don't update the docs. I prefer it to fail in the PR than to fail in master.

This check has always been there and from time to time there are broken links we need to fix. It is not something new. I agree it is PITA, I would vote to remove this check, but we need something to ensure that master is green/published. Something that forces us to fix broken links from time to time.

@jgsogo jgsogo merged commit ebe7bdf into conan-io:develop Mar 23, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants