Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msbuild generator #1732

Merged
merged 3 commits into from Jun 9, 2020
Merged

msbuild generator #1732

merged 3 commits into from Jun 9, 2020

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Jun 8, 2020 •
edited

@memsharded memsharded added this to the 1.26 milestone Jun 8, 2020
danimtb
danimtb approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@danimtb danimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the property files automatically included to my solution if I am using the MSBuild() build helper?

reference/generators/msbuild.rst Outdated Show resolved Hide resolved
reference/generators/msbuild.rst Outdated Show resolved Hide resolved
memsharded and others added 2 commits June 9, 2020 12:30
@memsharded @danimtb
Update reference/generators/msbuild.rst
cbebcea 
Co-authored-by: Daniel <danimanzaneque@gmail.com>
@memsharded @danimtb
Update reference/generators/msbuild.rst
64be30a 
Co-authored-by: Daniel <danimanzaneque@gmail.com>
@memsharded
Copy link
Member Author

Are the property files automatically included to my solution if I am using the MSBuild() build helper?

No, we will not mess with user solutions or projects, the users need to explicitly add the properties files (from the generator).

@memsharded memsharded mentioned this pull request Jun 9, 2020
Merged
@memsharded memsharded merged commit 8e95bba into conan-io:develop Jun 9, 2020
@memsharded memsharded deleted the feature/msbuild branch June 9, 2020 10:43
@memsharded memsharded mentioned this pull request Jun 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danimtb danimtb danimtb approved these changes

Assignees

@danimtb danimtb

Labels
None yet
Projects
None yet
Milestone
1.26
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@memsharded @danimtb