Remove experimental warning #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danimtb
approved these changes
Jul 1, 2020
jgsogo
reviewed
Jul 1, 2020
creating_packages/package_repo.rst
Outdated
| @@ -101,7 +101,8 @@ Capturing the Remote and Commit: ``scm`` | |||
|
|
|||
| .. warning:: | |||
|
|
|||
| This is an **experimental** feature subject to breaking changes in future releases. | |||
| Depending on the use, this feature may be considered **experimental** and subject to breaking | |||
| changes in future releases. See :ref:`note <scm_to_conandata_note>` below. | |||
There was a problem hiding this comment.
I'd add everything here, not referring to another note below
reference/conanfile/attributes.rst
Outdated
| @@ -1257,7 +1257,8 @@ scm | |||
|
|
|||
| .. warning:: | |||
|
|
|||
| This is an **experimental** feature subject to breaking changes in future releases. | |||
| Depending on the use, this is feature may be considered **experimental** and subject to breaking | |||
| changes in future releases. See :ref:`note <scm_to_conandata_note>` below. | |||
There was a problem hiding this comment.
Same here, I would keep the "experimental warning/note" everything inside a single callout.
jgsogo
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes from experimental two conan features:
scm_to_conandata