Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental warning #1759

Merged
merged 5 commits into from Jul 1, 2020

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Jul 1, 2020

This PR removes from experimental two conan features:

  • Revisions
  • The use of scm mode but only when used with scm_to_conandata

@czoido czoido requested a review from memsharded Jul 1, 2020
@czoido czoido added this to the 1.27 milestone Jul 1, 2020
danimtb
danimtb approved these changes Jul 1, 2020
@@ -101,7 +101,8 @@ Capturing the Remote and Commit: ``scm``

.. warning::

This is an **experimental** feature subject to breaking changes in future releases.
Depending on the use, this feature may be considered **experimental** and subject to breaking
changes in future releases. See :ref:`note <scm_to_conandata_note>` below.
Copy link
Member

@jgsogo jgsogo Jul 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add everything here, not referring to another note below

@@ -1257,7 +1257,8 @@ scm

.. warning::

This is an **experimental** feature subject to breaking changes in future releases.
Depending on the use, this is feature may be considered **experimental** and subject to breaking
changes in future releases. See :ref:`note <scm_to_conandata_note>` below.
Copy link
Member

@jgsogo jgsogo Jul 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, I would keep the "experimental warning/note" everything inside a single callout.

@czoido czoido requested a review from jgsogo Jul 1, 2020
jgsogo
jgsogo approved these changes Jul 1, 2020
@jgsogo jgsogo merged commit 8f44274 into conan-io:develop Jul 1, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants