Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate docs #1947

Merged
merged 1 commit into from Dec 3, 2020
Merged

validate docs #1947

merged 1 commit into from Dec 3, 2020

Conversation

memsharded
Copy link
Member

@memsharded memsharded added this to the 1.32 milestone Dec 2, 2020
raise ConanInvalidConfiguration("Option 2 of 'dep' not supported")


If a package uses ``compatible_packages`` feature, it should not add to those compatible packages configurations that will not be valid,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this section, I think it is more important to show how a compatible package (a valid one) will be used to substitute an invalid package. Something with the compiler.cppstd is very evident: the package is invalid (will fail with conan create) if using C++11, but a conan install will use a compatible one that was built using C++14,17,20.

These comments about what packages to add to self.compatible_packages belong to the documentation of the compatible_packages feature.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this is also a valid use case, in which you can fallback to release artifacts in Linux if you don't have the debug one, which usually works in non-windows platforms. I am not sure if I understand the issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an issue, I think that the other use case is much more interesting regarding validate + compatible-packages. Falling back to Release builds I think it is more related to compatible-packages than validate, and this is the documentation for the validate function. One example is enough, the other is better IMO.

@czoido czoido merged commit d502746 into conan-io:develop Dec 3, 2020
@memsharded memsharded deleted the feature/validate branch December 3, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants