Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake_layout #2141

Merged
merged 2 commits into from Jun 30, 2021
Merged

cmake_layout #2141

merged 2 commits into from Jun 30, 2021

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Jun 29, 2021 •
edited

@memsharded memsharded requested a review from lasote June 29, 2021 15:26
@memsharded memsharded added this to the 1.38 milestone Jun 29, 2021
@memsharded memsharded mentioned this pull request Jun 29, 2021
Merged
lasote
lasote requested changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@lasote lasote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be useful and didactic to document that the build folder is xxx for single config and yyy for multi and the default for the cpp.build and cpp.source. Otherwise is too much of a magic black box with unknown behavior

@memsharded
Copy link
Member Author

I think it might be useful and didactic to document that the build folder is xxx for single config and yyy for multi and the default for the cpp.build and cpp.source. Otherwise is too much of a magic black box with unknown behavior

Agree, I will add its implementation and comment it.

lasote
lasote approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@lasote lasote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@czoido czoido merged commit 173fa86 into conan-io:develop Jun 30, 2021
@memsharded memsharded deleted the feature/cmake_layout branch June 30, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasote lasote lasote approved these changes

Assignees

@czoido czoido

Labels
None yet
Projects
None yet
Milestone
1.38
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@memsharded @lasote @czoido