Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pkg-lists #3257

Merged
merged 13 commits into from Jun 15, 2023
Merged

Pkg-lists #3257

merged 13 commits into from Jun 15, 2023

Conversation

memsharded
Copy link
Member

@memsharded memsharded added this to the 2.0.7 milestone Jun 14, 2023
@memsharded memsharded mentioned this pull request Jun 14, 2023
Merged
RubenRBS
RubenRBS approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, some grammar typos and a few wording suggestions, but otherwise reads great. Seeing it like this really shows how useful this feature can be for the right users :)

examples/commands/pkglists.rst Outdated Show resolved Hide resolved
examples/commands/pkglists.rst Outdated Show resolved Hide resolved
examples/commands/pkglists.rst Outdated Show resolved Hide resolved
examples/commands/pkglists.rst Outdated Show resolved Hide resolved
examples/commands/pkglists.rst Outdated Show resolved Hide resolved
examples/commands/pkglists.rst Outdated Show resolved Hide resolved
introduction.rst Outdated Show resolved Hide resolved
tutorial/other_features.rst Outdated Show resolved Hide resolved
memsharded and others added 7 commits June 15, 2023 10:04
@memsharded @RubenRBS
Update examples/commands/pkglists.rst
4a54f7e 
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
@memsharded @RubenRBS
Update examples/commands/pkglists.rst
482a16f 
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
@memsharded @RubenRBS
Update examples/commands/pkglists.rst
74b94c4 
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
@memsharded @RubenRBS
Update examples/commands/pkglists.rst
ae7ad5f 
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
@memsharded @RubenRBS
Update examples/commands/pkglists.rst
59131e4 
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
@memsharded @RubenRBS
Update introduction.rst
f9fc964 
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
@memsharded @RubenRBS
Update tutorial/other_features.rst
e735a07 
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
franramirez688
franramirez688 reviewed Jun 15, 2023
View reviewed changes
examples/commands/pkglists.rst
@@ -0,0 +1,176 @@
.. _examples_commands_pkglists:

Using packages-lists
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the same name for the title and the rest of the mentions.

@memsharded @RubenRBS
Update examples/commands/pkglists.rst
99f9e7b 
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
@czoido czoido merged commit 77ff6ef into conan-io:develop2 Jun 15, 2023
2 checks passed
@memsharded memsharded deleted the feature/pkglists branch June 15, 2023 09:20
@memsharded
Copy link
Member Author

Good, I will do those changes later, when I add the remove --list docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franramirez688 franramirez688 franramirez688 left review comments

@czoido czoido czoido approved these changes

@RubenRBS RubenRBS RubenRBS approved these changes

Assignees

@czoido czoido

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
2.0.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@memsharded @franramirez688 @czoido @RubenRBS