Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for name/version being allowed in build_folder_vars conf #3636

Merged
merged 2 commits into from Mar 19, 2024
Merged

Add docs for name/version being allowed in build_folder_vars conf #3636

merged 2 commits into from Mar 19, 2024

Conversation

RubenRBS
Copy link
Member

@RubenRBS RubenRBS added this to the 2.2.0 milestone Mar 18, 2024
@RubenRBS RubenRBS mentioned this pull request Mar 18, 2024
Merged
memsharded
memsharded approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

The feature is actually more powerful, it can use any recipe attribute, like self.context or anything that resembles a string. But I think it is better to document it only for name/version at the moment.

@czoido czoido merged commit f5c87fe into conan-io:develop2 Mar 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

Assignees

@czoido czoido

Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RubenRBS @memsharded @czoido