[PkgConfigDeps][MesonToolchain] Added build context folder mechanism #3640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
reviewed
Mar 19, 2024
| @@ -111,6 +111,8 @@ you can activate it using the **build_context_activated** attribute: | |||
| build_context_suffix | |||
| ^^^^^^^^^^^^^^^^^^^^ | |||
|
|
|||
| *DEPRECATED: use build_context_folder attribute instead* | |||
There was a problem hiding this comment.
Is this true for autotools projects too? Or only for Meson? I think only Meson has the capability of specifying a folder for the build-requires?
There was a problem hiding this comment.
MesonToolchain has the build.pkg_config_path variable, but I did not figure out how to do that in Autotools. Any ideas?
czoido
reviewed
Mar 19, 2024
memsharded
reviewed
Mar 19, 2024
| build_context_suffix | ||
| ^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| *DEPRECATED: use build_context_folder attribute instead* |
There was a problem hiding this comment.
It is still not very clear that the deprecation of this and the recommendation to use build_context_suffix is the way to go also for autotools. If it is not, maybe we should recommend this for Meson only?
Maybe we need to understand the potential autotools usages of the build_context_suffix and build_context_folder
czoido
reviewed
Mar 20, 2024
czoido
approved these changes
Mar 20, 2024
memsharded
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for conan-io/conan#15813. (MesonToolchain explanation is covered by the docstring)