Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conan runner docs added #3699

Merged
merged 31 commits into from
May 6, 2024
Merged

Conversation

davidsanfal
Copy link
Contributor

@davidsanfal davidsanfal commented Apr 29, 2024

@CLAassistant
Copy link

CLAassistant commented Apr 29, 2024

CLA assistant check
All committers have signed the CLA.

@davidsanfal davidsanfal added this to the 2.3.0 milestone Apr 30, 2024
@davidsanfal davidsanfal marked this pull request as ready for review April 30, 2024 13:03
Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. These are just mostly wording suggestions, but I have a few comments in some sections too :)

reference/runners.rst Outdated Show resolved Hide resolved
reference/runners.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
reference/runners/docker.rst Outdated Show resolved Hide resolved
davidsanfal and others added 10 commits May 6, 2024 16:36
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
davidsanfal and others added 8 commits May 6, 2024 16:38
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
reference/runners.rst Outdated Show resolved Hide resolved
davidsanfal and others added 8 commits May 6, 2024 17:23
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
@czoido czoido self-assigned this May 6, 2024
@czoido czoido merged commit 313343b into conan-io:develop2 May 6, 2024
2 checks passed
franramirez688 pushed a commit to Neeeflix/conan-docs that referenced this pull request Jun 4, 2024
* conan runner docs added

* Update reference/runners.rst

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

* Update reference/runners.rst

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

* Update reference/runners/docker.rst

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

* Update reference/runners/docker.rst

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

* Update reference/runners/docker.rst

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

* Update reference/runners/docker.rst

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

* Update reference/runners/docker.rst

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

* Update reference/runners/docker.rst

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

* Update reference/runners/docker.rst

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

* Update reference/runners/docker.rst

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

* docker runners examples added

* basic docker runner example updated

* Update reference/runners.rst

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

* Update reference/runners/docker.rst

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>

* note about package id added

* Update examples/runners/docker/basic.rst

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

* conan docker runner basic example updated

---------

Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants