Documented cmaketoolchain:extra_variables (#16229) #3719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
perseoGI
changed the title
5 tasks
RubenRBS
approved these changes
May 16, 2024
|
|
||
| conan install . -c "tools.cmake.cmaketoolchain:extra_variables*={'CMAKE_GENERATOR_INSTANCE': 'C:/Program Files (x86)/Microsoft Visual Studio/2017/BuildTools/'}" | ||
|
|
||
| .. tip:: |
There was a problem hiding this comment.
TIL! Can I get a pic of how this looks when built?
There was a problem hiding this comment.
It looks good to me, but maybe it is not what we want.
As a noobie, I like command examples so that's why I added it. And also the *= looks very important because really nobody read the docs xD
perseoGI
force-pushed
the
perseoGI/16222-feature-cmake_generator_instance
branch
from
bcbb681
to
280a069
Compare
perseoGI
force-pushed
the
perseoGI/16222-feature-cmake_generator_instance
branch
from
280a069
to
5e626a8
Compare
danimtb
reviewed
Jun 4, 2024
memsharded
requested changes
Jun 4, 2024
There was a problem hiding this comment.
The dict is not very readable or didactical. I think an incremental approach, starting with a single {"MYCMAKEVAR": "Myvalue"} is better:
- Simple complete use case of the
extra_variables - Use something better than
STRbecause that seems a type, not a variable name. - Single line that fits in the screen
Then explain the .cmake generated from it, and explain clearly that it is injected later so it can overwrite.
Then, finally, explain the advanced syntax, with the whole dict with the type, cache and docstring.
RubenRBS
reviewed
Jun 5, 2024
Co-authored-by: Rubén Rincón Blanco <rubenrb@jfrog.com>
czoido
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentation for new
cmaketoolchainoptionextra_variablesRefers to: conan-io/conan#16242