languages and cstd support #3757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
approved these changes
Jun 4, 2024
| Regarding ``languages`` definition, the following will happen: | ||
|
|
||
| - If no ``languages`` is defined or ``C`` is not a declared language, ``compiler.cstd`` subsetting will be automatically removed | ||
| at package ``configure()`` time (to achieve backward compatibility). |
There was a problem hiding this comment.
Suggested change
| at package ``configure()`` time (to achieve backward compatibility). | |
| at package ``configure()`` time (to achieve backward compatibility). | |
| Thus Conan assumes that ``C++`` is the default value for ``languages`` if not overriden by the user. |
There was a problem hiding this comment.
Not super accurate, it will not be reported languages = "C++" if it is not defined in any of the places it is reported (json output, dependencies interface, etc), it will be an empty list. So it is not the default value, the default value is an empty list.
| @@ -29,6 +29,12 @@ recipe to remove them so they are not used in the recipe: | |||
| # No need to delete those settings here, they were already deleted | |||
| pass | |||
|
|
|||
| .. note:: | |||
|
|
|||
| From Conan 2.4, the above ``configure()`` is not necessary if defined ``languages = "C"`` recipe | |||
There was a problem hiding this comment.
Suggested change
| From Conan 2.4, the above ``configure()`` is not necessary if defined ``languages = "C"`` recipe | |
| From Conan 2.4, the above ``configure()`` is not necessary if defining ``languages = "C"`` as a recipe |
There was a problem hiding this comment.
It would be more like in the recipe? Or as a recipe attribute?
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
czoido
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for conan-io/conan#16028