Add hook: recipe linting #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we include it to Conan Center? As linter was embedded in Conan, all recipes were checked by pylint before. |
|
It can be useful for Conan Center too, of course. |
|
Please, don't forget to add it in README file :) |
uilianries
reviewed
Dec 4, 2019
| import astroid # Conan 'pylint_plugin.py' uses astroid | ||
| from pylint import epylint as lint | ||
| except ImportError as e: | ||
| sys.stderr.write("Install pylint to use 'recipe_linter' hook: 'pip install pylint astroid'") |
|
Please consider adding some nice comments in the escaping chars line and the ANSI one for clarification |
danimtb
reviewed
Dec 5, 2019
danimtb
approved these changes
Dec 5, 2019
uilianries
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hook to lint recipes. It should substitute Conan built-in (conan-io/conan#6152)
Not to be merged before conan-io/conan#6152, it might require additional requirements in this repo.
test_dynamic_fieldsshould only run with theconans.pylint_plugin.pywith the python_requires added.