Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for Python 2.7 #156

Merged
merged 10 commits into from Feb 11, 2020
Merged

Conversation

danimtb
Copy link
Member

@danimtb danimtb commented Feb 11, 2020

Seems there was a major change in virtualenv when they bumped the version to 20.0.0 - For some reason this caused the pyenv creation to fail only in Python 2.

This is a temporal fix for it until we drop Python 2 support from testing.


closes #155

@danimtb danimtb self-assigned this Feb 11, 2020
@danimtb danimtb changed the title Install newer six version Fix CI for Python 2.7 Feb 11, 2020
@conan-io conan-io deleted a comment from uilianries Feb 11, 2020
@danimtb danimtb marked this pull request as ready for review February 11, 2020 11:29
.travis.yml Outdated
@@ -86,7 +86,7 @@ install:
pyenv activate conan;
fi
- pip install --upgrade pip
- pip install tox tox-venv
- pip uninstall -y -r <(pip freeze)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done to avoid conflicts with pluggy (requirement of pytest in the travis env and the requirement of tox and tox-env installed by us)

@danimtb danimtb requested a review from jgsogo February 11, 2020 12:12
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this one!

@jgsogo jgsogo merged commit d9e6839 into conan-io:master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants