Run tests within the same python process #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thin the same python process)
jgsogo
commented
Jan 23, 2019
| self.assertEqual(return_code, expected_return_code, | ||
| msg="Unexpected return code\n\n{}".format(output_stream.getvalue())) | ||
| finally: | ||
| conan_api._remote_manager._auth_manager._localdb.connection.close() # Close sqlite3 |
There was a problem hiding this comment.
Conan is not closing the connection to the database 😮 , we need to close it in order to remove the working directory.
|
Sounds like integration tests. |
uilianries
reviewed
Jan 23, 2019
danimtb
approved these changes
Jan 28, 2019
|
Quite smooth and seems the way to go! 👍 |
3 tasks
danimtb
pushed a commit
to danimtb/hooks
that referenced
this pull request
May 27, 2019
…shared_post_build Removed shared artifacts check in post_build()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I want to share with you this trick to run the tests, I'm calling the Conan
mainfunction (not actually because it contains somesys.exitcalls in case of failure) to run the commands.We think this is almost the best approach to run the tests:
Let me know your thoughts about it.