[fix] Add decorator to raise if failure in post_package_info #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ericLemanissier
approved these changes
May 25, 2021
|
This also explains why KB-H019 was reporting an error for meson, but never made any build actually fail. With this change, all the packages depending on meson will start failing. EDIT: actually it won't fail, the error was corrected already conan-io/conan-center-index#4420 |
|
I have in the pipeline a PR to show warnings from hooks... just waiting for a good use-case to test and implement the details. My plan is to start testing it with this one #294 once we start using that Conan version in CCI. |
danimtb
approved these changes
May 25, 2021
4 tasks
|
What is blocking this PR from being merged ? https://c3i.jfrog.io/c3i/misc/logs/pr/5691/7/qt/5.15.2/00d1496a6c968613f776d9af8b01eb24b30ad01b-build.txt is another case where an error is detected, but silently swallowed |
uilianries
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for: conan-io/conan-center-index#4528
It might affect other packages or PRs