Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topics should be lowercase, even proper names, acronyms and initialisms #346

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

garethsb
Copy link
Contributor

Extend KB-H064 to check for uppercase. Based on conan-io/conan-center-index#6891 (comment).

@uilianries
Copy link
Member

Thank yoU!

@uilianries
Copy link
Member

Pylint is broken, the minor version 2.11 changed its behavior. The #280 has a fix, which avoids 2.11 for now.

Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like lowercase topics 👍

At some point in time, we need to work on showing the warnings to the user in CCI, otherwise it is hard to realize about them... but it's good to have the checks already there.

@jgsogo jgsogo requested a review from uilianries October 6, 2021 16:33
@jgsogo
Copy link
Contributor

jgsogo commented Oct 6, 2021

pylint issue was fixed here: #349

@jgsogo jgsogo merged commit 9345dda into conan-io:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants