Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Ramda as a peer dependency #76

Open
luisvasq opened this issue Sep 19, 2020 · 0 comments
Open

Issue with Ramda as a peer dependency #76

luisvasq opened this issue Sep 19, 2020 · 0 comments

Comments

@luisvasq
Copy link

Hi Alex and Team!,

It's been a long time. I hope you all are doing well and staying safe!

I have an issue with conflicting versions of ramda when specifying ramda and framework-x as regular dependencies in my project. I'm using npm v7.0.0-beta.11 in a monorepo and it fails with the following error log:

npm ERR! While resolving: framework-x@0.1.46
npm ERR! Found: ramda@0.27.1
npm ERR! node_modules/ramda
npm ERR!   ramda@"^0.27.1" from the root project
npm ERR!
npm ERR! Could not add conflicting dependency: ramda@0.26.1
npm ERR! node_modules/ramda
npm ERR!   peer ramda@"^0.26.1" from framework-x@0.1.46
npm ERR!   node_modules/framework-x
npm ERR!     framework-x@"^0.1.46" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --legacy-peer-deps or --force
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Since I'm not working with any breaking change introduced in ramda>=0.27, there are two quick solutions for me: downgrade ramda to 0.26.1 or use the --legacy-peer-deps flag (default behavior on npm<7). However, I see that it might be convenient to move the ramda dependency on framework-x to the dependencies group, as any project that depends on framework-x could rely on a different version of ramda or even depend on a different functional library.

As you know, framework-x is a core dependency of the CAVE framework, so it was great when I saw you open sourced this project. 😀

I'm super excited for version 1!!! 🚀

Luis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant