Skip to content
This repository has been archived by the owner on Feb 22, 2020. It is now read-only.

Factor out EXTRACTED_IMAGE_DIR #208

Closed
5 tasks
lamby opened this issue Nov 2, 2017 · 1 comment
Closed
5 tasks

Factor out EXTRACTED_IMAGE_DIR #208

lamby opened this issue Nov 2, 2017 · 1 comment

Comments

@lamby
Copy link
Contributor

lamby commented Nov 2, 2017

We use EXTRACTED_IMAGE_DIR in a few places in the code, eg in prediction/src/algorithms/identify/prediction.py:

21:EXTRACTED_IMAGE_DIR = "data/extracted/"

This should be factored out into a more suitable location (eg. a setting or configuration - see elsewhere for prior art).

It should also use os.path.join for extra bonus points!

Checklist before submitting

  • I have confirmed this using the officially supported Docker Compose setup using the local.yml configuration and ensured that I built the containers again and they reflect the most recent version of the project at the HEAD commit on the master branch
  • I have searched through the other currently open issues and am confident this is not a duplicate of an existing bug
  • I provided a minimal code snippet or list of steps that reproduces the bug.
  • I provided screenshots where appropriate
  • I filled out all the relevant sections of this template
@DrAmygdala
Copy link
Contributor

Hi,

Could I work on this one? This is my first issue here.

Thanks

@lamby lamby closed this as completed in #214 Nov 8, 2017
lamby pushed a commit that referenced this issue Nov 8, 2017
Serhiy-Shekhovtsov pushed a commit to Serhiy-Shekhovtsov/concept-to-clinic that referenced this issue Nov 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants