Skip to content
This repository has been archived by the owner on Feb 22, 2020. It is now read-only.

Annotation: per-nodule notes should actually be PATCHed and saved #280

Closed
isms opened this issue Jan 5, 2018 · 5 comments
Closed

Annotation: per-nodule notes should actually be PATCHed and saved #280

isms opened this issue Jan 5, 2018 · 5 comments
Labels
enhancement interface-frontend major official
Milestone
3-packaging

Comments

@isms
Copy link
Contributor

isms commented Jan 5, 2018 •
edited

Expected Behavior

Manipulating these should be PATCHed to the backend and saved in the appropriate model instance:
image

Current Behavior

No-op
@isms isms added this to the 3-packaging milestone Jan 5, 2018
@Serhiy-Shekhovtsov
Copy link
Contributor

I'd like to take this one.

@Serhiy-Shekhovtsov
Copy link
Contributor

@isms, I can see that we are using PATCH for updating the candidate. Is there a reason for using POST here?

@isms
Copy link
Contributor Author

isms commented Jan 11, 2018

@Serhiy-Shekhovtsov no, not at all, PATCH is the right verb 👍

@isms isms changed the title Annotation: per-nodule notes should actually be POSTed and saved Annotation: per-nodule notes should actually be PATCHed and saved Jan 11, 2018
@isms
Copy link
Contributor Author

isms commented Jan 11, 2018

(issue updated to say PATCH - thanks Serhiy)

@Serhiy-Shekhovtsov Serhiy-Shekhovtsov mentioned this issue Jan 16, 2018
Merged
1 task
@Serhiy-Shekhovtsov
Copy link
Contributor

@isms the issue is solved in PR #286

@reubano reubano closed this as completed Jan 16, 2018
@isms isms unassigned lamby Oct 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement interface-frontend major official
Projects
None yet
Milestone
3-packaging
Development

No branches or pull requests
4 participants
@lamby @reubano @Serhiy-Shekhovtsov @isms