Improved sliding window - trim old context #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to prevent exceeding token limits
hack is to trim them, recognizing the LLM answer may not be ideal...
khalp
approved these changes
Sep 6, 2023
Jetchat/app/src/main/java/com/example/compose/jetchat/data/CustomChatMessage.kt
Outdated
Show resolved
Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/data/CustomChatMessage.kt
Outdated
Show resolved
Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/data/Tokenizer.kt
Outdated
Show resolved
Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/data/CustomChatMessage.kt
Outdated
Show resolved
Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/data/CustomChatMessage.kt
Outdated
Show resolved
Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/data/CustomChatMessage.kt
Outdated
Show resolved
Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/data/CustomChatMessage.kt
Outdated
Show resolved
Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/data/CustomChatMessage.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+303
to
+304
| // ONLY show date/time when embeddings are empty, as it triggers the SessionsByTime function (I THINK) | ||
| // ALWAYS add the date and time to every prompt |
There was a problem hiding this comment.
Suggested change
| // ONLY show date/time when embeddings are empty, as it triggers the SessionsByTime function (I THINK) | |
| // ALWAYS add the date and time to every prompt | |
| // ONLY show date/time when embeddings are empty, as it triggers the SessionsByTime function |
hoping the "i think" has been resolved 😜
| role = completionMessage.role, | ||
| content = completionMessage.content | ||
| userContent = completionMessage.content | ||
| ?: "", // required to not be empty in this case |
There was a problem hiding this comment.
is this still true with the custom chat message class? or can we remove the null check now
Co-authored-by: Kristen Halper <khalper@microsoft.com>
Co-authored-by: Kristen Halper <khalper@microsoft.com>
Co-authored-by: Kristen Halper <khalper@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and also trim 'current' context if it exceeds the limit (rare but possible bug)