Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2 breaks 2.3.5 release #41

Closed
augustf opened this issue Aug 15, 2017 · 6 comments
Closed

1.2 breaks 2.3.5 release #41

augustf opened this issue Aug 15, 2017 · 6 comments
Assignees

Comments

@augustf
Copy link
Member

augustf commented Aug 15, 2017

When attempting to build 2.3.5, I got an issue with the RSS and video plugins I could not resolve. It didn't come up during testing or build but only for users upgrading their Concerto. This broke the Concerto VM severely. The message was "Downloading concerto_simple_rss-1.2 revealed dependencies not in the API or
the lockfile".
screen shot 2017-08-14 at 8 45 19 pm
I was forced to revert the entire release, as the error could not be resolved on any of my installations.

@mfrederickson
Copy link
Contributor

@augustf from the screenshot above, it looks like the rss plugin worked ok, or am I missing something?

@mfrederickson
Copy link
Contributor

Just documenting my findings so far....
Concerto master branch seems to bundle fine on development machine.
selection_213

@mfrederickson
Copy link
Contributor

It looks like none of the changes to the Gemfile.lock are making it into the release (and thus into the deb package). I thought changes to master would be included in the draft release... I guess I have to assign a new tag to the draft release, then publish the release for the tag to be created, then change it back to a draft release.

@mfrederickson
Copy link
Contributor

I updated the release (by giving it a new tag) and it now includes your commits and mine, and the concerto-full package installs fine on my test concerto vm. Please try again and let me know. The release name 2.3.5 doesn't match the tag 2.3.5.1 and I didn't know if you wanted to change that or not.

@mfrederickson
Copy link
Contributor

BTW, I resolved the bundler errors by the recommended route of removing the Gemfile.lock and letting it get rebuilt. rake test then showed that an airbrake update was breaking so I locked it at it's previous major version. I updated my bundler, and rebuilt the Gemfile.lock, rake tested, repackaged, copied the full deb to my vm and installed it via dpkg -i, and all worked fine.

@mfrederickson
Copy link
Contributor

@augustf interesting-- when I edited the release to a prerelease with the new tag, the public activity says that you created that tag.... anyway, might want to uncheck the prerelease checkbox once you're happy with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants