Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading new integration: Best practices? #232

Closed
phillipadsmith opened this issue Dec 13, 2016 · 3 comments · Fixed by #234
Closed

Loading new integration: Best practices? #232

phillipadsmith opened this issue Dec 13, 2016 · 3 comments · Fixed by #234

Comments

@phillipadsmith
Copy link
Member

So, when loading the Telegram integration for the first time, I'm seeing an error as follows:

System has started. Hello World!
Concierge-bot> /kpm install https://github.com/concierge/telegram.git
Attempting to install module from "https://github.com/concierge/telegram.git"...
Loading module 'telegram'... 	Installing "tgfancy" from npm.
Installation complete.
Installing "configstore" from npm.
Installation complete.
[DONE]
"telegram" (4) is now installed.
"!CORE!" threw up. <unknown> is now covered in sick.

... so I'm wondering, what is the best way to approach this need for the configuration (token, etc.) before the module is loaded and started?

@drkno
Copy link
Member

drkno commented Dec 13, 2016

You can use /kpm config before loading any module. Additionally, the current integrations are only reading their config after start is called (requires /kpm start). In load, the configuration might be initialised (defaults set) but not read.

@phillipadsmith
Copy link
Member Author

Additionally, the current integrations are only reading their config after start is called (requires kpm start). In load, the configuration might be initialised (defaults set) but not read.

Ah, yes, that makes sense. I'll fix that up.

@drkno
Copy link
Member

drkno commented Dec 19, 2016

Do you feel it would help to have this mentioned in the docs? If so I suggest merging it into #227.

@drkno drkno added the In PR label Dec 27, 2016
@drkno drkno mentioned this issue Dec 27, 2016
drkno pushed a commit that referenced this issue Dec 28, 2016
* Resolves #230
* Resolves #229
* Resolves #232
* Better resolution of script paths in hubot
* Add system module concept and remove config module
* Update documentation
* Integrations best practises documentation
* Check if existing module has been loaded before loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants