add a form helper to reduce boilerplate #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopefully this doesn't make things confusing. the goal is to help a developer focus on the logic of using the token service this also adds a secure:start option
pjanik
approved these changes
May 20, 2021
example-app/src/index.tsx
Outdated
| const [filePublicUrl, setFilePublicUrl] = useState(""); | ||
|
|
||
| // TODO hacky | ||
| const tokenServiceEnv: "dev" | "staging" = rawTokenServiceEnv as "dev" | "staging"; |
There was a problem hiding this comment.
It seems pretty okay to me in practice. If we wanted to be super safe, we could possibly add something like that:
Suggested change
| const tokenServiceEnv: "dev" | "staging" = rawTokenServiceEnv as "dev" | "staging"; | |
| const tokenServiceEnv: "dev" | "staging" = rawTokenServiceEnv === "dev" || rawTokenServiceEnv === "staging" ? rawTokenService : "staging"; |
or even some better logic there. This should prevent updates of tokenServiceEnv while the user is typing and assigning it to values like "d", "de", "st", "sta", "stagi", etc. But I don't think it matters at all in practice in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hopefully this doesn't make things confusing.
the goal is to help a developer focus on the logic of using the token service
this also adds a
npm run start:securescript.