Make client isomorphic as a node library #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the client library to be used in node applications, with the small change that `env` will be required, and the application will need to pass in an isomorphic replacement for `fetch` (presumably `node-fetch`).
scytacki
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
Looks good to me.
I'm going to add @dougmartin as a co-reviewer though just to double check what he thinks.
dougmartin
approved these changes
Jun 15, 2021
| const {jwt, serviceUrl} = options; | ||
| this.jwt = jwt; | ||
| this.env = options.env || getEnv(); | ||
| this.serviceUrl = getServiceUrlFromQueryString() || serviceUrl || getServiceUrlFromEnv(this.env) || serviceUrls.production; | ||
| this.fetch = ("fetch" in options) ? options.fetch : fetch; | ||
| } |
There was a problem hiding this comment.
I think it would be good to throw an exception here if this.fetch === undefined. This will make debugging easier for future users. The exception could be something like:
new Error("fetch not found in options or window object")
There was a problem hiding this comment.
👍 Sounds good, added.
| } | ||
| if (options?.body) { | ||
| requestOptions.body = JSON.stringify(options.body); | ||
| } | ||
| return fetch(url, requestOptions) | ||
| return this.fetch(url, requestOptions) |
There was a problem hiding this comment.
See note about throwing an exception in the constructor as this.fetch could be undefined here if not found in the options (node) or in the window object (browser).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the client library to be used in node applications, with the small change that
envwill be required, and the application will need to pass in an isomorphic replacement forfetch(presumablynode-fetch).