Escape backticks in multi-line strings with the default theme #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use snapshots for these tests, because the bug under test affects AVA's snapshots. Releasing the fix would change the fix's snapshots.
Actually use snapshots anyway. The bug only affects the reports, and it would already affect the existing quote-escaping tests.
|
Nice find!
Luckily only when they're updated, and hopefully it'll be clear enough in the diff that a bug was fixed. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36. This turned out to be a one-character typo in the default theme. The existing tests used a custom theme, preventing them from catching the bug.
This PR fixes the typo and adds test coverage for quote escaping with the default theme.
Shipping this will be a little interesting; it'll affect probably a lot of AVA snapshot reports out in the wild, including concordance's own snapshots, including the snapshots for this PR's own tests. It shouldn't affect the
.snapfiles, just the reports, so I think it's safe to ship as a minor or patch version. Might want to follow up by updating concordance's snapshots though.IssueHunt Summary
Referenced issues
This pull request has been submitted to: