Fix the vault lookup template env value

[gowrisankar22]

Existing Issue

concourse/concourse#5738

Why do we need this PR?

Fix the lookup template example.

Changes proposed in this pull request

• Fix the lookup template example.

Contributor Checklist

Are the following items included as part of this PR? Please delete checkbox items that don't apply.

• Variables are documented in the README.md

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not
fill out this section.

• Code reviewed
• Topgun tests run
• Back-port if needed

[taylorsilva]

Thanks for the fix! I think we can improve on this though and leave the original example as-is. It makes sense to have this variable still be a list of strings instead of a single string that happens to represent a list. In the end we do need a string but a list of strings is easier to manage/reason about and is a more accurate representation of this variable's type.

We can get the desired result by doing a join before quote'ing. Using quote alone results in a string representation of the list which is why the default example breaks. By adding join we get to define the separator and create the string in the correct format.

diff --git a/templates/web-deployment.yaml b/templates/web-deployment.yaml
index d75ad70..0afea90 100644
--- a/templates/web-deployment.yaml
+++ b/templates/web-deployment.yaml
@@ -507,7 +507,7 @@ spec:
             {{- end }}
             {{- if.Values.concourse.web.vault.lookupTemplates }}
             - name: CONCOURSE_VAULT_LOOKUP_TEMPLATES
-              value: {{ .Values.concourse.web.vault.lookupTemplates | quote }}
+              value: {{ .Values.concourse.web.vault.lookupTemplates | join "," | quote }}
             {{- end }}
             - name: CONCOURSE_VAULT_AUTH_BACKEND
               value: {{ .Values.concourse.web.vault.authBackend | quote }}

With the above change the web-deployment template renders a comma separated string instead of a string representation of a list:

            - name: CONCOURSE_VAULT_LOOKUP_TEMPLATES
              value: "/{{.Team}}/{{.Pipeline}}/{{.Secret}},/{{.Team}}/{{.Secret}}"

vs the original:

            - name: CONCOURSE_VAULT_LOOKUP_TEMPLATES
              value: "[/{{.Team}}/{{.Pipeline}}/{{.Secret}} /{{.Team}}/{{.Secret}}]"

wdyt?

[gowrisankar22]

@taylorsilva it makes sense. I bumped the change. Please check