Golang 1.20 breaks fly integration tests

[xtremerui]

Summary

golang 1.20 seems breaks (or makes them flaky) tests wherever there is stdin.close(). It is probably due to changes in os/exec package.

Steps to reproduce

Run concourse fly integration tests with go 1.20 and observe error as below example:

logging in to team 'main'


target saved
logging in to team 'main'


target saved


• Failure [0.311 seconds]
login -k Command login to new target with invalid SSL with -k [It] succeeds 
github.com/concourse/concourse/fly/integration/login_insecure_test.go:53

  Unexpected error:
      <*fs.PathError | 0xc000988bd0>: {
          Op: "close",
          Path: "|1",
          Err: <*errors.errorString | 0x1b4cab0>{
              s: "file already closed",
          },
      }
      close |1: file already closed
  occurred

  github.com/concourse/concourse/fly/integration/login_insecure_test.go:62

Expected results

Test passed

Actual results

Test failed

Additional context

The race condition seems happen more often in a slower env. In the case of Concourse CI, the errors are happening in external darwin worker.

Triaging info

• Concourse version: 7.9.0
• Browser (if applicable):
• Did this used to work? yes

[xtremerui]

We will hold on to Golang 1.19.5 until this issue is resolved.