New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit status 1 from sanitize_cgroups when system has cgroups subsystem available but the container process is not in it #170

Closed
jama-pivotal opened this Issue Jan 25, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@jama-pivotal
Member

jama-pivotal commented Jan 25, 2018

This line:

https://github.com/concourse/docker-image-resource/blob/master/assets/common.sh#L17

Fails due to set -e even though it's a variable assignment. This prevents the next line from checking and handling this condition correctly.

@vito vito changed the title from common.sh script fails if system has cgroups configured but the container process is not in it to exit status 1 from sanitize_cgroups when system has cgroups subsystem available but the container process is not in it Jan 25, 2018

mhuangpivotal added a commit that referenced this issue Mar 8, 2018

Do not exit if container process is not found in cgroups
#170

Signed-off-by: Shash Reddy <sreddy@pivotal.io>

@vito vito added the accepted label Mar 19, 2018

@vito vito closed this Mar 19, 2018

@vito vito added this to the v3.10.0 milestone Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment