fix additional_private_registries on alpine #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Standley <michael.standley@tempus.com>
|
@xtremerui can you please review my PR? |
|
Hi thank you for the PR. Is it possbile to add a test here? docker-image-resource/tests/out_test.go Line 273 in fff93fb |
yes @xtremerui -- added! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
additional_private_registriesparameter (from this PR: #345) is broken when when this resource type is built using the alpine linux Dockerfile, but it works as intended using the ubuntu Dockerfile.The reason for this is because alpine's
base64doesn't accept--decode. Both ubuntu and alpine understand-d, so let's change it to pass that instead.Crucially, the docker-image resource type bundled with concourse is built from the alpine Dockerfile, so
additional_private_registrieswill not work until this is merged, released, and bundled into a new version of concourse.