Feature/reject invalid filter format #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenech
force-pushed
the
feature/reject-invalid-filter-format
branch
from
08d9029
to
cc0575e
Compare
fenech
force-pushed
the
feature/reject-invalid-filter-format
branch
2 times, most recently
from
df38303
to
c55ca6c
Compare
fenech
force-pushed
the
feature/reject-invalid-filter-format
branch
2 times, most recently
from
b5510cd
to
bef9d2f
Compare
Return an error from the check if the parameter is not an array, rather than quietly failing to apply the filter. Before this change, the jq command failed due to a parse error and no filter was applied. Signed-off-by: Tom Fenech <tomjwfenech@gmail.com>
Signed-off-by: Tom Fenech <tomjwfenech@gmail.com>
Install missing package, which provides netstat Signed-off-by: Tom Fenech <tomjwfenech@gmail.com>
Signed-off-by: Tom Fenech <tomjwfenech@gmail.com>
fenech
force-pushed
the
feature/reject-invalid-filter-format
branch
from
bef9d2f
to
139f4ad
Compare
|
Awesome enhancement! I'll review and merge or give feedback. At a quick glance, everything looks pretty good! |
|
Thanks for the initial feedback @taylorsilva! Did you get a chance to look at it in the end? |
taylorsilva
reviewed
Mar 16, 2024
There was a problem hiding this comment.
Sorry for the delay @fenech IRL stuff pulled me away and I'm just getting back in the habit of checking stuff here. This PR is solid! Nice little improvements to the areas you had to touch and added a test too. THANK YOU for the PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this issue when I accidentally passed a single string to the "commit_filter.include" parameter. I was confused by the fact that the check appeared to work, but it returned the wrong commit.
Instead, this makes the check fail when the configuration of this parameter is incorrect.