Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#25] move external url from concourse-ci.org to pivotal.io #30

Merged
merged 2 commits into from
Apr 23, 2019

Conversation

YoussB
Copy link
Member

@YoussB YoussB commented Apr 15, 2019

All tasks from #25 have been completed.

  • Changed from concourse-ci.org to pivotal.io
  • Updated chart to use the latest helm repo
  • removed requirements.lock file and added it to .gitignore
  • Added web annotation to force recreate web pods on chart change

cc @taylorsilva

Copy link
Member

@cirocosta cirocosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except two points that might be worth discussing a bit 😁

deployments/with-creds/Makefile Outdated Show resolved Hide resolved
deployments/with-creds/hush-house/requirements.lock Outdated Show resolved Hide resolved
- Update Domain from concourse-ci.org to pivotal.io
- Update chart to use the latest helm repo
- Add web annotation to force recreate web pods on change

Signed-off-by: Taylor Silva <tsilva@pivotal.io>
Co-authored-by: Bishoy Youssef <byoussef@pivotal.io>
- Add rollingUpdate annotation to worker and web deployments so we can
do rolling updates only when we want
- Remove annotation setting from the Makefile
- Add note about new annotation in README

Signed-off-by: Taylor Silva <tsilva@pivotal.io>
Co-authored-by: Bishoy Youssef <byoussef@pivotal.io>
Signed-off-by: Taylor Silva <tsilva@pivotal.io>
Copy link
Member

@cirocosta cirocosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM 😁 Thanks!

@cirocosta cirocosta merged commit 7c706c7 into master Apr 23, 2019
@cirocosta cirocosta deleted the 25-domain-update branch April 23, 2019 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants