New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issues 89 #92
fix issues 89 #92
Conversation
Signed-off-by: Ye Yang <yangye@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting on this, but I think it needs a bit more. 🙂 Not sure if you're up for it since this started off so simple.
@vito please help to take a look |
Signed-off-by: Ye Yang <yangye@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, while resolving the merge conflicts I noticed there's another unbounded for {
loop in Set()
- would you mind limiting that loop too for consistency?
Signed-off-by: Ye Yang <yangye@vmware.com>
fixed anther loop. |
@vito could you take a look, the new change is satisfying your request? |
also run gofmt Signed-off-by: Jamie Klassen <cklassen@pivotal.io> Co-authored-by: James Thomson <jthomson@pivotal.io>
fix function name typo
Signed-off-by: Ye Yang <yangye@vmware.com>
Signed-off-by: Ye Yang <yangye@vmware.com>
Signed-off-by: Ye Yang <yangye@vmware.com>
fixed and rebased upstream master. thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - thanks!
documents concourse/semver-resource#92 Signed-off-by: Jamie Klassen <cklassen@pivotal.io> Co-authored-by: James Thomson <jthomson@pivotal.io>
#89