Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap in List! #5419

Closed
balazsbajorics opened this issue Apr 29, 2024 · 0 comments · Fixed by #5722
Closed

Wrap in List! #5419

balazsbajorics opened this issue Apr 29, 2024 · 0 comments · Fixed by #5722
Assignees
@liady
Milestone
1. Creation

Comments

@balazsbajorics
Copy link
Contributor

balazsbajorics commented Apr 29, 2024 •
edited by Rheeseyb
Loading

Related to #5442
@bkrmendy bkrmendy removed their assignment May 8, 2024
@liady liady self-assigned this May 8, 2024
@maltenuhn maltenuhn added this to the 1. Creation milestone May 13, 2024
@bkrmendy bkrmendy assigned bkrmendy and liady and unassigned liady and bkrmendy May 15, 2024
@liady liady mentioned this issue May 22, 2024
Merged
2 tasks
liady added a commit that referenced this issue May 23, 2024
@liady
Wrap in List (#5722)
17a8370 
**Problem:**
We cannot currently wrap with a List

**Fix:**
This PR fixes wrapping a single element with a list.

**Details:**
1. Adding a List as an option for "Wrap..."
2. Adjust the code so that wrapping in a map (which is currently two `INSERT`s in disguise) will actually `REPLACE` the map contents
3. NOTE - this PR supports a single element wrapping.

For multiple element wrapping see #5696

<video src="https://github.com/concrete-utopia/utopia/assets/7003853/0dfc0062-8c9a-4e19-9bfc-5a138f0a2df3"></video>

- [X] I opened a hydrogen project and it loaded
- [X] I could navigate to various routes in Preview mode

Fixes #5419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liady liady

Labels
None yet
Projects
None yet
Milestone
1. Creation
Development

Successfully merging a pull request may close this issue.

Wrap in List concrete-utopia/utopia
4 participants
@balazsbajorics @maltenuhn @liady @bkrmendy