Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show shadows in the inspector that don't use the utility fn #60

Closed
maltenuhn opened this issue Jun 8, 2020 · 1 comment
Closed

Show shadows in the inspector that don't use the utility fn #60

maltenuhn opened this issue Jun 8, 2020 · 1 comment
Assignees
Labels
Perceived Bug Something that feels broken or like a problem

Comments

@maltenuhn
Copy link
Member

STR

Example 1

  1. Insert a view
  2. give it a shadow. Note the utility function
  3. remove that shadow and replace it with a custom shadow, eg boxShadow: '0px 3px 5px 1px rgba(0,0,0,.25)'

Expected: shows up in in the inspector. Observed: it does not. Also applies to multiple shadows

Note: we originally introduced the utility fn because border would affect the layout and 'move' the box. Same with margin and why we didn't support it. This is no longer an issue, so I believe we could have border set real border, boxShadow a real box shadow, and retire the utility fn.

@maltenuhn maltenuhn added the Perceived Bug Something that feels broken or like a problem label Jun 8, 2020
@alecmolloy alecmolloy self-assigned this Jun 9, 2020
@maltenuhn
Copy link
Member Author

The shadow has landed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Perceived Bug Something that feels broken or like a problem
Projects
None yet
Development

No branches or pull requests

2 participants