-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update react-contexify to 6.0.0 #5725
Conversation
@@ -444,7 +444,6 @@ | |||
"eslint-plugin-jsx-a11y@6.5.1": "patches/eslint-plugin-jsx-a11y@6.5.1.patch", | |||
"karma-mocha-reporter@2.2.5": "patches/karma-mocha-reporter@2.2.5.patch", | |||
"keycode@2.2.1": "patches/keycode@2.2.1.patch", | |||
"react-contexify@5.0.0": "patches/react-contexify@5.0.0.patch", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted in PR description, let me know if (and how) this needs to be re-created for v6.
#12700 Bundle Size — 62.24MiB (~-0.01%).
Warning Bundle contains 51 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
Bundle analysis report Branch context-menu-update Project dashboard |
Would love some assistance on:
|
7e4d4ab
to
95ca238
Compare
The "try me" version doesn't seem to be working at all 😕, but it definitely does locally for me. |
show({ | ||
event: event, | ||
position: | ||
localXHack_KILLME === 'local-x-coord-KILLME' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benwolfram are we tracking this? we should really kill this localXHack!
this was meant as a temporary fix in a demo deadline push a few weeks ago, simply put here because we only had five minutes to fix the offset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, this wasn't on my todo list. I am not even sure what it is tbh, but I can take a look here soon in a future PR, as I was intending to wrap work on Context Menu.
editor/src/components/navigator/navigator-item/component-picker-context-menu.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some minor feedback but mostly looks good!
it looks like this PR broke |
95ca238
to
0893f76
Compare
f755a63
to
a18b632
Compare
Problem:
As apart of modernizing and updating context menus, bumping react-contexify to the latest version following their migration guide.
Fix:'
This PR fixes keyboard navigation for the context menu, however, events are still bubbling up to the editor. Will look at this next.
Bumping to version 6.0.0
Changing how
show
is called, with the eventUpdating classes and redoing the styles
Removing explicit 28px heights
Using
onVisibilityChange
Typescript type fixes
Removing the existing patch?
Manual Tests:
I hereby swear that:
Relates to #5643