Support circular referenced code. #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes #568. - Removed `dependencyOrdering` from `UiJsxCanvasProps`. - Deleted `reorderTopLevelElements`. - Deleted `elementDependencyOrdering`. - Removed `dependencyOrdering` from `ParseSuccess`. - Updated existing tests and added another for confirming that circular referenced components will render in the canvas.
seanparsons
requested review from
Rheeseyb,
balazsbajorics,
enidemi and
alecmolloy
Rheeseyb
approved these changes
Oct 2, 2020
enidemi
approved these changes
Oct 2, 2020
- `ParseSuccess` now includes `combinedTopLevelArbitraryBlock` which holds a merged block of all the arbitrary code at the top level of the file. - Canvas component now executes the combined top level arbitrary block instead of the individual ones. - Parser now produces the value for `combinedTopLevelArbitraryBlock` by accumulating all the arbitrary nodes collated across the top level of a file. - Tests updated and added to to cover the new functionality.
Rheeseyb
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #568
Problem:
Previously we had protection against circular references on the canvas because they could not be handled there.
Fix:
The canvas as it is currently actually supports circular references, so I removed all the protection functionality to allow those to go through.
Commit Details:
dependencyOrderingfromUiJsxCanvasProps.reorderTopLevelElements.elementDependencyOrdering.dependencyOrderingfromParseSuccess.circular referenced components will render in the canvas.